Verified:

Zorp

Member

825

Aug 13th 2018, 17:31:30

Zorp

Member

825

Aug 13th 2018, 17:31:40

cyref

Member

715

Aug 16th 2018, 14:30:38

Confirmed.
New set on Alliance.
And still not fixed.
https://www.youtube.com/watch?v=-Kx0szQJDC4
👽

Marshal

Member

28,751

Aug 16th 2018, 19:17:14

he forgot again
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

cyref

Member

715

Aug 26th 2018, 8:31:04

Your enemy lost:
20,040 Troops
46,265 Turrets
2172 Tanks
Their defence allies lost:
13,843 Troops
*I N S E R T T U R R E T L O S S E S H E R E*
1776 Tanks

still not fixed
👽

Marshal

Member

28,751

Aug 26th 2018, 10:37:02

well you know his memory.
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

drkprinc

Member

5107

Aug 26th 2018, 17:20:02

cyref we need to do a mass virgin sacrafice to get his attention.
(<(<>(<>.(<>..<>).<>)<>)>)

zz.ghqnet.com - 0.o
http://LaF.center - LaF
imp.ghqnet.com - IMP

Marshal

Member

28,751

Aug 26th 2018, 19:09:31

get him new gf and he will fix this.
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

cyref

Member

715

Aug 30th 2018, 0:48:08

unfixed uncorrected and
https://www.youtube.com/watch?v=aaSRYecKaqc

٩(●̮̮̃•)۶
👽

Zorp

Member

825

Sep 4th 2018, 2:37:07

srsly?

Marshal

Member

28,751

Sep 4th 2018, 14:26:55

well of course

qz is busy on tinder. :P
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

drkprinc

Member

5107

Sep 4th 2018, 15:17:18

someone setup a tinder profile with this thread as a person and swipe on QZ.
(<(<>(<>.(<>..<>).<>)<>)>)

zz.ghqnet.com - 0.o
http://LaF.center - LaF
imp.ghqnet.com - IMP

Marshal

Member

28,751

Sep 4th 2018, 19:58:08

you go ahead
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

Celphi

Member

5181

Sep 5th 2018, 16:59:12

BTW., I know how to fix this. I found the issue. A game moderator should contact me. :)
Resistance is futile. You will be assimilated.

Marshal

Member

28,751

Sep 5th 2018, 19:24:41

i'm sure qz and pang know too and izarc.
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

Celphi

Member

5181

Sep 5th 2018, 22:04:04

Goto the file send.php

Search for the variable

$turns->def_ally_losses->m_ta
$turns->def_ally_losses->m_tr
$turns->def_ally_losses->m_tu

Resistance is futile. You will be assimilated.

Zorp

Member

825

Sep 10th 2018, 15:22:43

Bo Nuss

Marshal

Member

28,751

Sep 10th 2018, 17:57:55

^nussii
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

Pang

Administrator
Game Development
5276

Sep 11th 2018, 1:23:04

Originally posted by Celphi:
Goto the file send.php

Search for the variable

$turns->def_ally_losses->m_ta
$turns->def_ally_losses->m_tr
$turns->def_ally_losses->m_tu



hmmm

that file and code pattern doesn't exist. you must be looking at old code.

which begs the question... where are you finding old code? :)
-=Pang=-
Earth Empires Staff
pangaea [at] earthempires [dot] com

Boxcar - Earth Empires Clan & Alliance Hosting
http://www.boxcarhosting.com

Celphi

Member

5181

Sep 11th 2018, 4:08:05


function send_attack() {
try {
$("#ajax_status #status_message").html("Preparing your forces...");
$("#ajax_status #status_image").attr("src", "/img/ajax-loader.gif");
var var_targetnum = $("#attack_info [name=targetcountry]").val();
var var_ATTTYPE = $("#attack_info [name=ATTTYPE]").val();
var var_ARMYTroop = $("#attack_info [name=ARMYTroop]").val();
var var_ARMYJet = $("#attack_info [name=ARMYJet]").val();
var var_ARMYTank = $("#attack_info [name=ARMYTank]").val();
var var_MISSILETYPE = $("#attack_info input[name=MISSILETYPE]").val();
var var_need_html = 0;
if ($("#att_result").html() == "") {
var_need_html = 1
}
var pathname = window.location.pathname;
$.ajax({
type: "POST",
url: pathname + "/ajax/send",
data: {
targetnum: var_targetnum,
ATTTYPE: var_ATTTYPE,
ARMYTroop: var_ARMYTroop,
ARMYJet: var_ARMYJet,
ARMYTank: var_ARMYTank,
MISSILETYPE: var_MISSILETYPE,
need_html: var_need_html
},
success: function(res) {
if (var_need_html) {
$("#att_result").html(res);
var json_response = $("#att_result #json_response").html();
$("#att_result #json_response").remove();
var att_results = eval("(" + json_response + ")")
} else {
var att_results = eval("(" + res + ")")
}
var inputs = {
targetnum: var_targetnum,
ATTTYPE: var_ATTTYPE,
ARMYTroop: var_ARMYTroop,
ARMYJet: var_ARMYJet,
ARMYTank: var_ARMYTank,
MISSILETYPE: var_MISSILETYPE,
need_html: var_need_html
};
show_attack_results(att_results, inputs);
$("#att_result").show()
},
error: display_error
})
} catch (error) {
display_error(error)
}
}


The ajax call is window.location.pathname + '/ajax/send' and since all the files don't include '.php' I'm assuming there's some apache rewrite rules to remove the .php
Resistance is futile. You will be assimilated.

UgolinoII

Member

249

Sep 11th 2018, 11:26:27

Might be a silly question... is this open source? Github URL?

Be happy to dig through and submit a pull request for this one. Could be show_attack_results() that is broke, but more likely the 'res' being returned to the success callback is at fault...

Marshal

Member

28,751

Sep 11th 2018, 14:15:17

not open source to prevent hax0rs like celphi finding exploitable bugs.

if ee code would be public some-many would look for exploits which wouls benefit them.
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

Celphi

Member

5181

Sep 11th 2018, 16:19:06

Javascript is always open and readable.

All the Javascript for EE is outdated. There’s lots of bugs and extra functions that people don’t even know about.

Resistance is futile. You will be assimilated.

Marshal

Member

28,751

Sep 11th 2018, 19:08:31

well ee was more or less hastily made so somewhat expected and time to fix those is luxury.
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

Pang

Administrator
Game Development
5276

Sep 12th 2018, 3:23:01

the new stuff I've been building is pretty mint :D

we built this game in like 4-5 weeks in like 2010 and not a lot has been changed since then (some things, but not a lot of UI-facing code).

and, without giving away too much info, Celphi's post about how the serverside code works is way off :p

we don't open source because, like Marshal said, it would cause more headaches than it's worth. plus copy cats show up.
-=Pang=-
Earth Empires Staff
pangaea [at] earthempires [dot] com

Boxcar - Earth Empires Clan & Alliance Hosting
http://www.boxcarhosting.com

Celphi

Member

5181

Sep 12th 2018, 3:38:46

"and, without giving away too much info, Celphi's post about how the serverside code works is way off :p"

Where did I mention anything about serverside code?
Resistance is futile. You will be assimilated.

Celphi

Member

5181

Sep 12th 2018, 3:50:20

It can't be too much of a secret. :P

It's either:

HTML templates (ie. smarty)
Apache rewrite rules for clean URLs
Or a dynamic controller that parses the URL
ie.
 define("DOCUMENT_ROOT", $_SERVER['DOCUMENT_ROOT']);
$url = getenv('REMOTE_ADDR');
$url = parse_url($url['path']);
if (file_exists(DOCUMENT_ROOT . $url . '.php')){
require_once(DOCUMENT_ROOT . $url . '.php');
} else {
//display 404 page
}

If I go to https://www.earthempires.com/team/war/ajax/info (then I see the JSON).
So what I said about the ajax isn't incorrect. :P


Edited By: Celphi on Sep 12th 2018, 3:56:32
Resistance is futile. You will be assimilated.

Celphi

Member

5181

Sep 12th 2018, 4:08:27

Also., the code I posted was Javascript (frontend) (not serverside) which anyone can see.
Resistance is futile. You will be assimilated.

Celphi

Member

5181

Sep 12th 2018, 4:15:38

And if it doesn't use the Turns object then that's why your allies info is broken.

if (a.def_ally_losses.m_tr != 0 || a.def_ally_losses.m_tu != 0 || a.def_ally_losses.m_ta != 0) {
b += "<div class='attblue'>Their defence allies lost: </div>";
if (a.def_ally_losses.m_tr > 0) {
b += wrap_n_item(addCommas(a.def_ally_losses.m_tr) + " Troops")
}
if (a.def_ally_losses.m_j > 0) {
b += wrap_n_item(addCommas(a.def_ally_losses.m_tu) + " Turrets")
}
if (a.def_ally_losses.m_ta > 0) {
b += wrap_n_item(addCommas(a.def_ally_losses.m_ta) + " Tanks")
}
}


Check out the functions:
show_attack_results(a, b)
creat_attack_result_html(a)

success: function(res) {
if (var_need_html) {
$("#att_result").html(res);
var json_response = $("#att_result #json_response").html();
$("#att_result #json_response").remove();
var att_results = eval("(" + json_response + ")")
} else {
var att_results = eval("(" + res + ")")
}
var inputs = {
targetnum: var_targetnum,
ATTTYPE: var_ATTTYPE,
ARMYTroop: var_ARMYTroop,
ARMYJet: var_ARMYJet,
ARMYTank: var_ARMYTank,
MISSILETYPE: var_MISSILETYPE,
need_html: var_need_html
};
show_attack_results(att_results, inputs);
$("#att_result").show()
},


So if you follow the 'a' variable you see it's a result of the ajax call whose url is at url: pathname + "/ajax/send"
Resistance is futile. You will be assimilated.

Pang

Administrator
Game Development
5276

Sep 12th 2018, 5:09:15

Ok, I still think you're not on the right track with a lot of this discussion but since it's already posted here... the actual error as to why it doesn't show turrets is as follows:


if (a.def_ally_losses.m_j > 0) {
b += wrap_n_item(addCommas(a.def_ally_losses.m_tu) + " Turrets")
}


Notice that we are looking at jets and not turrets for the test in the if. It's coded really poorly, but that's the whole problem right there. Changing m_j to m_tu in the check will resolve the problem. I've got a branch going with some changes for this file, I'll throw this in too.

Thanks!

Edited By: Pang on Sep 12th 2018, 5:13:07
See Original Post
-=Pang=-
Earth Empires Staff
pangaea [at] earthempires [dot] com

Boxcar - Earth Empires Clan & Alliance Hosting
http://www.boxcarhosting.com

Gerdler

Member

1551

Sep 12th 2018, 18:07:58

WOW! That's just epic lol.

Cyref will you buy the Champagne?

Marshal

Member

28,751

Sep 12th 2018, 19:10:53

he's too cheapskate.
Patience: Yep, I'm with ELK and Marshal.

ELKronos: Patty is more hairy.

Galleri: Sadly pics of my boobies are on my ftp-folder.

LadyGrizz boobies is fine

NOW3P: Morwen is a much harsher mistress than boredom....

cyref

Member

715

Sep 12th 2018, 19:25:23

YESSSSSsssssss!
top shelf all around!
https://www.youtube.com/watch?v=yVj8Sh4phzM
👽

Leto

Member

131

Sep 23rd 2018, 18:34:22

Yeah the losses are high with this one

Getafix

Member

2804

Sep 24th 2018, 10:54:50

Why should the game give out free information about allies? Get a spyop.

cyref

Member

715

Sep 24th 2018, 11:26:16

It's not free information. You have to landgrab to see the attack result report.
The attack result report includes the DA's losses of troops and tanks.
The fact that it does not report turret losses is not a feature.
Obviously the intention was to include turret losses.
It's a bug.
👽

Getafix

Member

2804

Sep 24th 2018, 13:44:36

If I have a high spal country that you can't get an op on, you shouldn't change the game to make it easier for you to see what I have by hitting one of my DA's.

cyref

Member

715

Sep 24th 2018, 15:28:43

The attack result report only displays the combined losses of the DAs, not any particular allied country's losses/tech/other DA.
It is not like getting an op on a country allied to my landgrab target.
You could say fixing any bug changes the game but really it is only fixing a bug, whether the bug is a few hours or many years old.
You could say this bug changed the game when it appeared eight years ago.
Most players would like to see bugs fixed.
👽

Getafix

Member

2804

Sep 24th 2018, 21:04:26

All one would need to do is feed the ally op data into the Zorpomatic and estimate the size of the missing DA I expect. :) I miss the Zorpomatic, I must admit.

Primeval

Game Moderator
Mod Boss
2277

Sep 24th 2018, 22:06:21

Originally posted by cyref:
The attack result report only displays the combined losses of the DAs, not any particular allied country's losses/tech/other DA.
It is not like getting an op on a country allied to my landgrab target.
You could say fixing any bug changes the game but really it is only fixing a bug, whether the bug is a few hours or many years old.
You could say this bug changed the game when it appeared eight years ago.
Most players would like to see bugs fixed.


Agreed. This was intended information.

cyref

Member

715

Dec 27th 2018, 18:54:20

NEVER FORGET
👽

Gerdler

Member

1551

Dec 29th 2018, 6:53:11

wow so the bugged code was identified and not rectified. hmm.

I thought it was all this time that the devs didn't understand what the problem was as previous responses have indicated over the years.

LittleItaly

Game Moderator
FFA
1870

Dec 29th 2018, 8:57:50

Problem is, from what Pang said, he updated it in his development branch, but didn't "fast track" the bug fix upstream.
LittleItaly
SOL Vet
-Discord: LittleItaly#2905
-IRC: irc.scourge.se #sol
-Apply today @ http://sol.ghqnet.com for Alliance